Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Connections now inherit from "MySQLConnection" if a MySQL server is detected (server version < 10.0). The new mysql argument to dbConnect() allows overriding the autodetection #303

Merged
merged 9 commits into from
Oct 7, 2023
Merged

feat: Connections now inherit from "MySQLConnection" if a MySQL server is detected (server version < 10.0). The new mysql argument to dbConnect() allows overriding the autodetection #303

merged 9 commits into from
Oct 7, 2023

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Oct 6, 2023

to support declaring that the backend database is MySQL.

@krlmlr krlmlr changed the title Add mysql argument to MariaDB() feat: Add mysql argument to MariaDB() Oct 6, 2023
@krlmlr krlmlr requested review from hadley and jeroen October 6, 2023 14:46
@krlmlr
Copy link
Member Author

krlmlr commented Oct 6, 2023

We could also use mysql_get_server_version() to try to infer automatically,https://dev.mysql.com/doc/c-api/8.0/en/mysql-get-server-version.html .

@krlmlr krlmlr mentioned this pull request Oct 7, 2023
Open
@krlmlr
Copy link
Member Author

krlmlr commented Oct 7, 2023

Autodetection works beautifully. The mysql argument now has moved to dbConnect(). I also don't think there's a conflict with the RMySQL package because I'm using the constructor functions returned by setClass() .

@krlmlr krlmlr changed the title feat: Add mysql argument to MariaDB() feat: Connections now inherit from "MySQLConnection" if a MySQL server is detected (server version < 10.0). The new mysql argument to dbConnect() allows overriding the autodetection Oct 7, 2023
@krlmlr krlmlr merged commit ae21d4b into main Oct 7, 2023
1 check passed
@krlmlr krlmlr deleted the f-mysql branch October 7, 2023 18:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hadley hadley Awaiting requested review from hadley

@jeroen jeroen Awaiting requested review from jeroen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krlmlr